glib: 2.84.4 -> 2.85.4; gjs: 1.84.2 -> 1.85.2#437764
Closed
pyrox0 wants to merge 2 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nixpkgs-ci
Bot
added
the
2.status: merge conflict
nixpkgs-ci
Bot
removed
the
2.status: merge conflict
nixpkgs-ci
Bot
added
10.rebuild-linux: 501+
nix-owners
Bot
requested review from
7c6f434c,
bobby285271,
dasj19,
hedning,
jtojnar and
lovek323
Member
Author
|
@LordGrimmauld I was able to build this PR, but I got build errors from gjs. Do you have any suggestions for how i could fix this, besides just disabling the test? Its not one that seems to have broken before, so idk why its breaking now(also sorry for a ping like 2 days after you asked in the sec discussions channel, got busy irl) |
Contributor
|
There also was the spidermonkey bump, i am not sure whether gjs built after that one at all (and testing is quite painful). Do you have a log? |
Member
|
Since I was able to build this on 6067f89, if you cannot build this here you can probably first try reverting glib to 2.85.3 (then maybe you will need to bisect glib). FYI these updates are development releases and it is very unlikely for any of the |
Member
Author
|
How do I know what releases are development or not? |
Contributor
|
gnome has a odd-unstable release model for their libraries. That means 2.84 is stable while 2.85 is dev. |
Member
|
Thanks for the PR. Now absorbed by #440720 Though two tests now fail: gjs:Scripts / Gtk4Warningsgjs:JS / PackageIf I revert the gjs bump, only one of them fails: gjs:JS / Package |
Member
Author
|
Closing in favor of #440720 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily to upgrade gjs to use a non-EOL(in 3 weeks) version of spidermonkey. Current test failures as discussed on matrix, but this branch is here so folks can help debug that issue.
Edit: Note that at this time, this is not ready to merge, as
gjsfails to build.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.